Nic Cope

Results 846 comments of Nic Cope

I'm not aware of any provider that targets OpenShift at the moment. Is there an API Crossplane could call to provision OpenShift clusters?

Thanks @jpmcb! This looks good, but similar to the thread at https://github.com/crossplane/crossplane/pull/3099#discussion_r881080373 you'll need to reflect these changes in a few other places to account for our v1alpha1 CompositionRevision feature.

I was just about to approve this, but it occurred to me that we already support `ToBase64` in the "convert" type of string transform. I think this might be a...

Ah - there's also (unfortunately) currently a bit of boilerplate conversion code that needs to be updated whenever we add a new transform or patch type. See https://github.com/crossplane/crossplane/pull/3158 for an...

Yeah, sadly this is a painful known issue. We've discussed writing a validation webhook for it since CRD machinery can't handle it internally - that seems like the most promising...

I'm not sure about compatibility with _all of_ `kstatus` - e.g. adding all of the "abnormal true" statuses mentioned at https://github.com/kubernetes-sigs/cli-utils/tree/45a0b5b7e6b292c0a59c899aa50a3662a0c1cf7d/pkg/kstatus#statuses. That said, if tooling like FluxCD is starting to...

> Likely, we’d either rename Healthy to Ready or add another one. Conditions are intended to be machine parseable, so renaming would be a breaking change. I think we'd need...

@erikgb I'm on board with adding a `Ready` condition to all resources (e.g. packages etc) alongside their existing ones. `observedGeneration` sounds good to me too.

> How would this be implemented? @MisterMX I'm empathetic to the fact this might require a lot of code changes, but we should prioritize API design here. We have more...

> The term spec.composite.patches implies to me that I am patching to the composite by default. This does not play nicely with the existing FromComposite* and ToComposite* patch types. Good...