Neetika Singhal

Results 23 comments of Neetika Singhal

Would love to get feedback from the community for this: @andrross @sohami @reta @mch2 @shwetathareja @Bukhtawar @rohin @ankitkala

thanks @shwetathareja for your feedback. > > Trying to understand Option 2 which is your preferred choice: > > > While index.store.data_locality > > helps in initializing the shard in...

> Focusing on the option 2: > > > No cluster state entry is kept for migrations, so there is some space we save on not keeping the custom cluster...

> Thanks for the proposal @neetikasinghal I agree with approach 2 of using internal API calls for shard level update. Like you pointed out, it should be easier to track...

> I would avoid a polling service to start with, I gave a basic pass wondering how is this substantially different from a snapshot custom entry where different shards undergo...

> ❌ Gradle check result for [31256f3](https://github.com/opensearch-project/OpenSearch/commit/31256f3c584fbd21c99fe589cb485749c83ad775): [FAILURE](https://build.ci.opensearch.org/job/gradle-check/43023/) > > Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure [a flaky...

> ❕ Gradle check result for [31256f3](https://github.com/opensearch-project/OpenSearch/commit/31256f3c584fbd21c99fe589cb485749c83ad775): [UNSTABLE](https://build.ci.opensearch.org/job/gradle-check/43053/) > > Please review all [flaky tests](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) that succeeded after retry and create an issue if one does not already exist to...

Checking more on how searchable snapshot deals with it - Its dealt with in the search path itself rather than introducing a new index setting for the warm index: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/cluster/routing/OperationRouting.java#L244...

@dblock please review, let me know if there is anything else that needs to be added.

> Glad you're adding an API with specs! > > Will need working tests as part of the PR, otherwise looking ok. is there any other tests you are looking...