com.unity.entities icon indicating copy to clipboard operation
com.unity.entities copied to clipboard

Isn't a Correct Mirror of com.unity.entities

Open Kleptine opened this issue 1 year ago • 4 comments

First off, the needle mirrors are fantastic. Thanks so much for hosting them.

I've noticed that the needle com.unity.entities package does not function correctly. It seems to be missing files and is otherwise different than the package downloaded from the package manager. This means it doesn't compile, and isn't usable. :\

See: https://twitter.com/BrendonSmuts/status/1415327153596547076

Easy repro:

  • Setup a new Unity Entities project or sample.
  • Swap the com.unity.entities package for this repo in the package json.
  • Observe compiler errors in the entities package.

Kleptine avatar Jun 27 '23 22:06 Kleptine

Hello John,

thanks for making an issue, that tweet seems to have slipped through.

Missing cs files is indeed unexpected and shouldnt happen. Could this file be produced by codegen perhaps by some dll/binary file that is stripped?

Do you have a specific version (latest entities + 2022.3 ?) that I should test this with to repo?

marwie avatar Jun 28 '23 07:06 marwie

Latest should do it, yep! Although I saw it a few versions back as well, so seems pretty easy to reproduce. Let me know if you can't though.

Edit: Yeah 2022.3.0f1 for me, but again, seen it on other engine versions, too.

Kleptine avatar Jun 28 '23 07:06 Kleptine

Reproduced with the following logs:

image

Package endpoint: https://packages-v2.unity.com/com.unity.entities Package tgz: https://download.packages.unity.com/com.unity.entities/-/com.unity.entities-1.0.11.tgz


Interesting sidenote/warning when selecting script in editor (after replacing registry version with mirror version)

image

marwie avatar Jun 28 '23 07:06 marwie

image

marwie avatar Jun 28 '23 07:06 marwie