Ned Twigg

Results 639 comments of Ned Twigg

> I am not familiar with Spotless' code at all Reporting a bug/enhancement is a great help, and it comes with no obligation to contribute a fix on the part...

Hi @hnoson. Just wanted to give you some insight into the merge conflicts. We've maintained support back to Gradle 2.x, and we're finally breaking that and adopting all the latest...

The brief upheaval in Spotless' core has ended. I fixed the merge conflicts and made some small edits to the PR to adjust for the new APIs in Spotless. All...

> is it only merge conflicts with main that is necessary to get this PR through? I don't think there's a huge amount of work left, but there is more...

Sounds great. Don't feel a need to support every use-case, just supporting your own use-case in a mostly-future-proof way is plenty to get merged. People can extend to support their...

I believe this a ktlint limitation, not Spotless. See [this comment](https://github.com/diffplug/spotless/issues/719#issuecomment-710270652) about yellers vs solvers - there are some things that ktlint yells about but can't solve, this might be...

Thanks, that's good to know! Maybe we are somehow not calling ktlint correctly. Reopening!

Interesting, good idea! I think GitHub is doing `clone --depth=1`. Doing a `fetch origin main` right after sort of defeats the purpose of the shallow clone, and the user is...

Fair enough :). Can you fix #711 with [`fetch-depth: 0`](https://github.com/actions/checkout) (note that the link is to github actions documentation).

Let's keep it open, I still think it's a good idea.