Ned Twigg

Results 639 comments of Ned Twigg

Thanks to @bh-tt, starting with `plugin-gradle 6.9.0` and `plugin-maven 2.24.0`, the check for foreign-exes is now lazy. Still happy to merge a PR to allow new version regex. One thought...

> the .editorconfig of the project is currently not being picked up This is correct. If it were being accounted for, it would have to be included as part of...

If `ktlint` responded to exceeding max line length by autowrapping, then the `off/on` tags would work. But `ktlint` apparently doesn't respond by autowrapping, it just yells. For everything that `ktlint`...

We can make this work in the future. Probably the `spotless:off` / `spotless:on` mechanism isn't the right one, but maybe instead `spotless:lintoff:CODE_FOR_LINT`. For each lint, search for that string on...

Thanks for reporting! Very bizarre that this fixes it: https://github.com/batect/batect/pull/1254/commits/0df17d376ee50e3e28f120c7245bd1e10fd6dfcb I'm gonna keep this open since it's definitely a bug with a nice reproducible testcase.

That is surprising! Here's the codepath as it exists today, but #935 is gonna change things a bit. https://github.com/diffplug/spotless/blob/08bf08c88c289f66019ba746c7acf2481b52958b/plugin-maven/src/main/java/com/diffplug/spotless/maven/AbstractSpotlessMojo.java#L189-L209 https://github.com/diffplug/spotless/blob/08bf08c88c289f66019ba746c7acf2481b52958b/plugin-maven/src/main/java/com/diffplug/spotless/maven/AbstractSpotlessMojo.java#L215-L238 https://github.com/diffplug/spotless/blob/08bf08c88c289f66019ba746c7acf2481b52958b/plugin-maven/src/main/java/com/diffplug/spotless/maven/GitRatchetMaven.java#L59-L72

I believe this should be improved in `plugin-maven 2.17.7`. Can you report back @rjmunro?

Bummer :(. I'm surprised by this, but the good news is that `2.18.0` adds an up-to-date cache which should help a lot whether `ratchet` is on or off. (#935)

Yes, we have support for two binary tools in Spotless right now, happy to add another one. https://github.com/diffplug/spotless/blob/21b089f454ed2d50f929af71f1cae52421e32c55/lib/src/main/java/com/diffplug/spotless/python/BlackStep.java#L65-L70 https://github.com/diffplug/spotless/blob/21b089f454ed2d50f929af71f1cae52421e32c55/lib/src/main/java/com/diffplug/spotless/cpp/ClangFormatStep.java#L70-L84 I'm fine with making installation of the `buf` tool a problem...

Happy to take a PR that supports placing the year in multiple places.