Ned Twigg

Results 639 comments of Ned Twigg

This lgtm. Needs changelog entries under `Unreleased` for all three changelogs. Probably need to update `README` in `plugin-maven` and `plugin-gradle` as well.

Try putting the googleJavaFormat step before the indent steps.

The android plugin must not be friends with [this code](https://github.com/diffplug/spotless/blob/master/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/JavaExtension.java#L140-L150).

I added the workaround in the top comment for others to find, along with links to the places where the code would need to be fixed if anyone wants to...

Just a bump that `src/*/java/**/*.java` will perform *far* better than `**/*.java`. We heavily discourage `**/blah` wildcards.

> the archives end up with Windows endings on a Windows machine and Unix endings on all other machines PLATFORM_NATIVE should work here, yeah?

I'm open to a `PRESERVE` option here: https://github.com/diffplug/spotless/blob/b2a2cbb8b6026397c0adb8cb8b3571e399276f9b/lib/src/main/java/com/diffplug/spotless/LineEnding.java#L45-L50 https://github.com/diffplug/spotless/blob/b2a2cbb8b6026397c0adb8cb8b3571e399276f9b/lib/src/main/java/com/diffplug/spotless/LineEnding.java#L134-L136 Two ambiguous cases: - file with zero line endings - file with both kinds of line endings My vote is that...

Making this change ```diff -wasm-opt = ['-O4', '--dce'] +wasm-opt = ['-g'] ``` takes the filesize from `1.1MB` to `1.4MB`. I then ran `twiggy top -n 100 pkg/rapier_wasm2d_bg.wasm` and I get:...

This PR might be necessary, but I'm not sure yet. We can stack the laziness to infinity `Set` -> `Provider` -> `Provider