Ned Twigg
Ned Twigg
My guess is that it's something about the target: > Snippet44d9c05216634f9eb348f8118d797947.groovy: **54: unexpected token: abstract @ line 54, column 15. !helper.abstract ^** That seems like a weird filename.
> it really makes jvm testing fun/easy Glad you like it! > should this happen at all? No, it should not: https://github.com/diffplug/selfie/blob/e6fb9e6a33b650c72aab3d5459ae1c22ab865cda/jvm/selfie-runner-junit5/src/main/kotlin/com/diffplug/selfie/junit5/SnapshotSystemJUnit5.kt#L71-L80 - I wonder if there is something similar...
This is a bug in GJF, not Spotless. You'll have to report it there.
> I would always expect spotless to do the same as GJF. I would expect that too, and so far I don't have any evidence that it doesn't. Have you...
Sorry for the long delay. - I don't think a configurable max makes sense. It should either be a brief summary or it should be complete. The default should be...
The thing I was using this for is still alive, but not currently under active development. I did a quick `git log` to look at the context from 2 years...
Not sure why, but on Java 11, JGit was causing [this to happen](https://github.com/diffplug/spotless/runs/35214243811). ``` - Class `org.eclipse.jgit.util.FS`: external process started '/usr/bin/git --version' See https://docs.gradle.org/8.4/userguide/configuration_cache.html#config_cache:requirements:external_processes - Class `org.eclipse.jgit.util.FS`: external process started...
Another benefit to bumping to Java 17 is that we could use the latest JGit, which adds worktree support.
It would also bump our required version of Gradle to 7.3, which would allow some minor simplifications here: - https://github.com/diffplug/spotless/blob/f22eda923e1a9d663f14b0db3f4918765023740c/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessPlugin.java#L30-L31 - https://github.com/diffplug/spotless/blob/f22eda923e1a9d663f14b0db3f4918765023740c/plugin-gradle/src/test/java/com/diffplug/gradle/spotless/GradleIntegrationHarness.java#L46-L50
With the pending release of Gradle 9, I think this is the right time for us to bump minimums, thanks to the linked PR by @Goooler above. If you need/want...