Ned Twigg

Results 639 comments of Ned Twigg

I think it might be because the XML parsing is trimming "meaningless" trailing newlines. If you specify a license *file* instead of an inline constant, then it should respect the...

To the best of my knowledge, this is a limitation of XML, there is no way to have significant trailing whitespace. So the workaround is the best we can do....

> I would argue that the extra newline should be added by default. Perhaps, but we aren't going to make a breaking change for this. > What about using CDATA...

Linting has not made it into `main` yet, it is in this PR: - https://github.com/diffplug/spotless/pull/2149 The API in that PR is quite firm, especially: `StepHarness expectLintsOf`, which is the API...

Thanks for this report! We have gone to great lengths to make our step's equality correct, but `7.0.0.BETA1` is a huge change so I'm not shocked if we got one...

Huh. So the point of this: https://github.com/diffplug/spotless/blob/059523c133cdf69a06ba909cee0b5a6d6dc7d07c/lib/src/main/java/com/diffplug/spotless/FormatterStepSerializationRoundtrip.java#L27-L29 Is that there is a `RoundtripState` which can have absolute paths in it. And then there is an `EqualityState` which is extracted from...

Re: `EndWithNewlineStep`, the code is correct. `EndWithNewlineStep` is not serializable, but `EndWithNewlineStep.class` **is serializable**. Because the step has no settings, it just needs a "key" for equality comparison. > Do...

Yeah, looks like there's a fundamental conflict here. Gradle uses the serialized representation of your task to do build cache, it does not respect `.equals`. But configuration cache requires your...

- This should be fixed in `plugin-gradle 7.0.0.BETA3` by #2298. Can you confirm @jprinet ?

@gendolf3d your issue seems like something new, feel free to open an issue if you have a reproducer