Ned Twigg comments

Results 639 comments of


                                            Ned Twigg

gradle: excluding spotlessJava should also exclude spotlessApply

The tasks are: - `spotlessJava` - `spotlessJavaApply` - `spotlessApply` I think `-xspotlessJavaApply` will do what you want already, that's probably the best answer. But `spotlessJava` is the slow task that...

toMatchDisk_TODO throws error when writing multiple snapshots to disk during parameterized tests, succeeds on follow ups.

Thanks for the report. It would be a lot easier to debug if the error message said: ``` Snapshot `rejects invalid commands/Node not found` was set to multiple values, first...

python: `to_be_file`

- [x] basic `to_be_file` implementation #366 - [x] needs `expect_selfie(actual: bytes) -> BinarySelfie` - means `BinaryFacet` - [x] needs `cache_selfie_binary` - ```python def cache_selfie_binary(to_cache: Cacheable[bytes]) -> CacheSelfieBinary[bytes]: ... def cache_selfie_binary(to_cache:...

python: `to_be_file`

Implemented!

pytest `snapshot_folder_name` and `allow_multiple_equivalent_writes_to_one_location`

We now have a `SelfieSettings`, but there are two parts missing: https://github.com/diffplug/selfie/blob/f1325e86308984401ecc86323f4d2d2e2b4f1d81/python/pytest-selfie/pytest_selfie/SelfieSettingsAPI.py#L15-L23 Users should be able to set them like so: https://github.com/diffplug/selfie/blob/f1325e86308984401ecc86323f4d2d2e2b4f1d81/python/pytest-selfie/pytest_selfie/SelfieSettingsAPI.py#L10 Right now our docs say something like this:...

docs for Python

- I setup publishing to PyPI (`pip install selfie-lib` now works). - I also setup https://github.com/diffplug/selfie/pull/317 Make sure to link to these places: - https://pypi.org/project/selfie-lib/ - https://pypi.org/project/pytest-selfie/ - https://pydoc.selfie.dev/ Optionally,...

.NET port

Needs DocFX at some point.

String constant too long

Max length of a String constant is 65535 when encoded as `CESU-8`. - https://stackoverflow.com/a/8323747

Python implementation (in progress)

We ended up dropping MyPy for pyright because pyright seems to be the only one that supports [PEP 695](https://docs.python.org/3/whatsnew/3.12.html#pep-695-type-parameter-syntax). The python implementation is in progress over at https://github.com/diffplug/selfie-python-wip, it will...

Python implementation (in progress)

We have archived `selfie-python-wip` and the last bits of integration work are going to happen in this repo. We are almost done. You can follow the schedule in - https://github.com/diffplug/selfie/issues/298