Ned Twigg
Ned Twigg
I left [feedback on your `captain-hook`](https://github.com/tjni/captain-hook/issues/1) project in your issue tracker, looks like a great project! > I'm wondering whether you think some of this logic can be extracted and...
@ShivamGoyal1899 PR's welcome, no work is scheduled. There's a workaround linked above, search "git hook script".
I don't think you need `-PdisableSpotlessCheck`, but otherwise it looks good to me. It's true that if you're working on a branch that isn't related to the `ratchetFrom` then you'll...
A good idea from [git-code-format-maven-plugin](https://github.com/Cosium/git-code-format-maven-plugin) is for the plugin to setup the git commit hooks itself. Worth looking into.
I think `ratchetFrom` would improve the situation for you, but doing one "stop the world and format everything" commit isn't a terrible idea to keep the noise from the change...
This is probably not specific to prettier, but rather our entire nodeJS integration: - https://github.com/diffplug/spotless/tree/main/lib/src/main/java/com/diffplug/spotless/npm - https://github.com/diffplug/spotless/tree/main/lib/src/main/resources/com/diffplug/spotless/npm This seems like a good idea, happy to take a PR for it.
Thanks for coming back!
lol after all that I delete the actual fix, lol. Thanks for checking and fixing!
I believe google-java-format is applied to these files, it's only the license header step which is not. https://github.com/diffplug/spotless/blob/45d2122c792927ec4ac7402ee7b10a5d495097d0/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/JavaExtension.java#L191-L193 https://github.com/diffplug/spotless/blob/45d2122c792927ec4ac7402ee7b10a5d495097d0/lib/src/main/java/com/diffplug/spotless/generic/LicenseHeaderStep.java#L39-L40 In order to fix this, we would need a smarter delimiter...
> I fail to see how your example above would allow (package|module)-info.java files to be formatted with google-java-format. Most of our users don't realize that the "steps" are independent -...