Ned Twigg

Results 639 comments of Ned Twigg

I don't think that will help. If someone builds and tests something I'm happy to merge it, but I don't care about this issue.

Thanks! We should build this into Spotless transparently. We can do it like this: - Move [`JreVersion`](https://github.com/diffplug/spotless/blob/main/testlib/src/main/java/com/diffplug/spotless/JreVersion.java) from `testlib` into `lib`, keep the `assume()` methods in testlib in a new...

Strange, I would expect this to work. We do some fancy stuff when parsing the target to make sure that `**/*` doesn't format stuff inside the `.git` directory for example,...

Very cool! > CI should have failed, since JUnit5 should have complained about missing engine. I assume you mean tests in `_ext/eclipse-cdt` should have failed? e.g. https://github.com/diffplug/spotless/blob/main/_ext/eclipse-cdt/src/test/java/com/diffplug/spotless/extra/eclipse/cdt/EclipseCdtFormatterStepImplTest.java They are not...

I think we want a new Gradle plugin [like this](https://github.com/diffplug/spotless-changelog/issues/30). ```gradle // settings.gradle if (getStartProperty('com.diffplug.spotless.include.ext') == 'ifgitdiff') { file('_ext').eachDirMatch(~/^(?!(\.|gradle)).*/) { dir -> ifGitDiff { folder dir, { include dir.name project(":${dir.name}").projectDir...

I implemented the idea above, with a few tweaks: - CI now runs `ext_test` on every commit. That means that it will run `test` for every `_ext` project which has...

I think all builds are working now, with easy publishing, except for the WTP, where the failures in `EclipseCssFormatterStepImplTest` look real to me. We could delete WTP for now and...

> Does Spotless support reformatting a text range rather than the whole file? No it does not. The Spotless model is that every formatter is just `f(String) -> String`, we...

Very interesting! Thanks for the detailed investigation. Are you using the default [`GIT_ATTRIBUTES` line endings policy](https://github.com/diffplug/spotless/tree/main/plugin-maven#line-endings-and-encodings-invisible-stuff), or are you setting it to `PLATFORM_NATIVE` manually? @fvgh, I think one way to...

A PR like this would be welcome, I would rather name it `importOrderGoogleJavaFormat(String version)`, because if I understand correctly it's a drop-in replacement for any of the `importOrder` algo's currently...