Ned Twigg

Results 639 comments of Ned Twigg

I think it is a user bug if a file is specified as a target by multiple formats. But it is a user bug which we should help with! When...

With Gradle, overlap checking only during a failed `check` is sufficient. This is because file caching happens per-format. If `A` and `B` are both formatting the same file, they will...

@ViliusS you can put all of that into one format. The java format has access to everything in the generic format. ```xml UNIX src/**/*.java true Blank line at the start...

Yes https://github.com/diffplug/spotless/blob/657926464aae27dee2c83c5b28ac6b7e52f2229a/plugin-maven/src/main/java/com/diffplug/spotless/maven/FormatterFactory.java#L136-L146 https://github.com/diffplug/spotless/blob/657926464aae27dee2c83c5b28ac6b7e52f2229a/plugin-maven/src/main/java/com/diffplug/spotless/maven/java/Java.java#L39

> the difference between the closing """ and the text MAY NOT BE ALTERED! It looks like the "source" and "reformatted" that you copy-pasted above are the same. Is that...

Ahhh, I see it now. You are correct, this is a problem in our indent step. ``` BEFORE

I am eager to add `cleanthat` to our code style. But change in our code style will cause merge conflicts, so this PR is also blocked on - #1096 -...

An opensource reproduction would be very welcome, I haven't seen this happen in my usage.

I hope we get an opensource reproduction someday, but in the meantime I bet that predeclaring deps will solve the issue. https://github.com/diffplug/spotless/tree/main/plugin-gradle#dependency-resolution-modes

Thanks @romtsn for the reproduction! @hobindar the massive slowdown in `6.6.0` will get fixed soonish, and can be worked around in the meantime by setting line endsings to `UNIX` or...