Ned Batchelder
Ned Batchelder
@webknjaz thanks, this does fix my issue.
I've confirmed that this pull request prevents the errors I reported.
@darius: I'm unlikely to do more work on byterun, so maybe we should find another owner...
@alanjds Could you do me a favor and squash these commits down to one? Also, I'm curious what you're using byterun for. :)
Also, a thing I learned about tox: the -e parameter is read from a TOXENV environment variable if it exists, so if you set TOXENV instead of TOX_ENV, then you...
Here are good instructions on how to squash the commits: http://davidwalsh.name/squash-commits-git You have an interesting idea, I did not think that byterun would be used to _actually_ run Python code....
@arthurp This is amazing! Thanks for all this work. Reviewing this would be easier if we could have separate PRs for the various aspects, though I understand that's difficult to...
@arthurp Could you tell us more about what you used this for in Google? It will help us understand the motivation for the refactoring.
@arthurp I think I'd like to do this: generalize byterun so that it can be subclassed as you want, but let's keep the specific subclasses out of the byterun repo....
@arthurp yes, you have the right idea. I'm not sure what changes from pyvm2 could go into AbstractVm, but I definitely don't like "increased code duplication". Take a stab at...