Ned Bass
Ned Bass
Commit 75543ec removed the commented out code from unifycr_print_chunk_list() shown below. This left a function stub behind that should be fully implemented or removed if it's not needed. ```c /*...
Commit 75543ecf7a32f5e4dcf6297ee02a51da7480c360 removed the commented out code from unifycr_get_chunk_list() shown below. This left a function stub behind that should be fully implemented or removed if it's not needed. ```c /*...
In client/src/unifycr-sysio.c, it looks like the error path on line 887 should call `free(glb_read_reqs)`. ```c 877 int UNIFYCR_WRAP(lio_listio)(int mode, struct aiocb *const aiocb_list[], 878 int nitems, struct sigevent *sevp) 879...
I get a floating point exception if I do the following: ``` $ salloc -N1 $ ./server.sh $ srun -N1 -n1 ./client/tests/test_write_static -s1 -b1 -t1 -f /tmp/foo srun: error: catalyst1:...
There are a number of compiler warnings related to the use of type-punning to reinterpret the memory type of message buffers: ``` unifycr.c: In function ‘unifycr_get_global_fid’: unifycr.c:942:5: warning: dereferencing type-punned...
unifycr_fid_close() is currently a placeholder and needs to be implemented
unifycr_fid_store_free() is currently a placeholder and needs to be implemented
On this line we have `if (op != MDHIM_GET_NEXT) {` https://github.com/LLNL/UnifyCR/blob/2cc38254e3bf25a07c2619bf5fdc577725568869/meta/src/range_server.c#L1029 Yet inside the if body there is code to handle `op == MDHIM_GET_NEXT`: https://github.com/LLNL/UnifyCR/blob/2cc38254e3bf25a07c2619bf5fdc577725568869/meta/src/range_server.c#L1042 and https://github.com/LLNL/UnifyCR/blob/2cc38254e3bf25a07c2619bf5fdc577725568869/meta/src/range_server.c#L1055 I'd like to...
Commit 75543ec removed the commented out function `unifycr_memcpy()` shown below. @adammoody [commented](https://github.com/LLNL/UnifyCR/pull/51#issuecomment-353477379) in #51 that it was there to facilitate performance testing of different memcpy variants with different compilers and...