react-strict-dom icon indicating copy to clipboard operation
react-strict-dom copied to clipboard
verified publisher icon facebook

feat: mark `inset*`, `marginBlock*`, `marginInline*`, `paddingBlock*` and `paddingInline*` props as built-in support

Open ecreeth opened this issue 1 year ago • 3 comments

This layout props have been implemented in main (default as of 0.76).

Check 46478 for more information.

Should we continue to test these props?

ecreeth avatar Oct 14 '24 19:10 ecreeth

I'm getting this coverage error:

Jest: "global" coverage threshold for branches (89%) not met: 88.79%

Weird... I didn't add any new functionality.

ecreeth avatar Oct 14 '24 19:10 ecreeth

We haven't been using the built in support because all logical styles aren't fully implemented in RN yet, and we had problems in the past with missing desktop support. I'll ask around and see if we can start to drop some of the polyfills

necolas avatar Oct 15 '24 15:10 necolas

Looks like a miss the direction prop. Now is supported on both platforms.

See https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/StyleSheet/StyleSheetTypes.d.ts#L114

ecreeth avatar Oct 22 '24 14:10 ecreeth