Illya Velychko
Illya Velychko
We are using [`react-sortable-hoc`](https://github.com/clauderic/react-sortable-hoc) library in the `app-form-builder`, and we might have issues because of that. Basically this library has not been supported for 2 years and it uses React...
@adrians5j, @SvenAlHamad what should we do about these bugs? While working on this feature we have found bug that exists for a long time. 1. When we have a form...
@leopuleo I have fixed issue with settings zod model
There are two solutions for this issue. First of the solutions is used in this PR, and the second one I will provide in this comment. In the second solution...
> And while I think we can tackle it, I think it's also important we check @SvenAlHamad's [comments](https://github.com/webiny/webiny-js/pull/3737#issuecomment-1845397945) he posted some time ago. > > Can we check that out?...
> But, the more interesting part is that the lib actually requires `lodash` internally 😅😅😅 > > All in all... I know we're going back and forth on this, but.......
> > But, the more interesting part is that the lib actually requires `lodash` internally 😅😅😅 > > All in all... I know we're going back and forth on this,...
> Yes please. > > Maybe it's worth exploring `@webiny/app-form-builder-condition-groups-validation` shared package? 🤔 > > Let's see how much code there will be and if there's a solid amount of...
> Btw. Maybe we should consider adding unit tests for validation as we have done it in [IconPicker](https://github.com/webiny/webiny-js/blob/f851660601bfadbb43324396ee412ec6628c826b/packages/app-admin/src/components/IconPicker/IconPickerPresenter.test.ts)? Because we would not need to manually test validation methods. @adrians5j what...
@SvenAlHamad Hi! I have updated UI for Rules tabs. Looking forward to your feedback! 1 - Rules for step 2 - Rules for condition group 3 - Rule with `Submit...