Nick De Villiers
Nick De Villiers
> LGTM just make sure to resolve those merge conflicts first
Closing as current version in maas-ui is ahead of this
We'll revisit this once we have a working proof-of-concept of React 19 in MAAS UI. WIP ;)
Wow, only two failing files, and they were exactly the ones I had expected to fail. I was really under the impression that this would be a lot more difficult......
@tmerten The second bug already has both UI and Backend fixed and merged (ability to select "Custom" as a layout option), but the backend fix for allowable layouts appears to...
Superseded by https://github.com/canonical/maas-ui/pull/5621
Hm, I'm getting some real strange behavior in tests surrounding a couple of selectors `src/app/subnets/views/VLANDetails/VLANDetails.tsx:39:19` ```ts const subnets = useSelector((state: RootState) => subnetSelectors.getByIds(state, vlan?.subnet_ids || []) ); ``` `src/app/machines/views/MachineDetails/MachineConfiguration/TagForm/TagForm.tsx:28:18` ```ts...
> Have you checked the bundle size impact of adding a new dependency? Good point - I'll run a before/after check. Although likelihood is we'll need this anyway for upcoming...
> > Have you checked the bundle size impact of adding a new dependency? > > Good point - I'll run a before/after check. Although likelihood is we'll need this...
>  > > It looks like the IP address field didn't show up for me. > > It looks like I'm in the correct...