Nick De Villiers

Results 14 comments of Nick De Villiers

> LGTM just make sure to resolve those merge conflicts first

Closing as current version in maas-ui is ahead of this

We'll revisit this once we have a working proof-of-concept of React 19 in MAAS UI. WIP ;)

Wow, only two failing files, and they were exactly the ones I had expected to fail. I was really under the impression that this would be a lot more difficult......

@tmerten The second bug already has both UI and Backend fixed and merged (ability to select "Custom" as a layout option), but the backend fix for allowable layouts appears to...

Superseded by https://github.com/canonical/maas-ui/pull/5621

Hm, I'm getting some real strange behavior in tests surrounding a couple of selectors `src/app/subnets/views/VLANDetails/VLANDetails.tsx:39:19` ```ts const subnets = useSelector((state: RootState) => subnetSelectors.getByIds(state, vlan?.subnet_ids || []) ); ``` `src/app/machines/views/MachineDetails/MachineConfiguration/TagForm/TagForm.tsx:28:18` ```ts...

> Have you checked the bundle size impact of adding a new dependency? Good point - I'll run a before/after check. Although likelihood is we'll need this anyway for upcoming...

> > Have you checked the bundle size impact of adding a new dependency? > > Good point - I'll run a before/after check. Although likelihood is we'll need this...

> ![Screenshot 2024-08-30 at 22 04 55](https://private-user-images.githubusercontent.com/18423198/363325765-b06e61ff-9da8-4355-8542-9df2f5c5cbe6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUyNjg2ODcsIm5iZiI6MTcyNTI2ODM4NywicGF0aCI6Ii8xODQyMzE5OC8zNjMzMjU3NjUtYjA2ZTYxZmYtOWRhOC00MzU1LTg1NDItOWRmMmY1YzVjYmU2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTAyVDA5MTMwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU0YjMyNmI4NzM4ZDVhOGFhYWI1MWI2ZjYzYWEzNjJhYThhNzg4OGUxNWQ3MTkxMjdjYTczY2M3MjJmZjNjZjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.t2OM5Ykcd4FZoMZrz3CCuNHelYogEgVXZXCKjAwELMs) > > It looks like the IP address field didn't show up for me. > > It looks like I'm in the correct...