Pisit Sawangvonganan

Results 7 comments of Pisit Sawangvonganan

FWIW, I built **"samples/net/wifi"** on the **"disco_l475_iot1"** board to compare the code footprint of `wifi_shell.c` among different options. | FOOTPRINT | ORIGINAL | OPTION1 | OPTION2 | OPTION3 (BELOW) |...

@EricNRS, I just realized the snippet was wrong it should be `CONFIG_SHELL_BACKEND_RTT` instead of `CONFIG_LOG_BACKEND_RTT`. So, I think this change would not relate to `CONFIG_LOG_*`

I've just discovered another PR (https://github.com/zephyrproject-rtos/zephyr/pull/68809) related to this fix that's already merged. Now, this begs the question: what is the actual solution for this matter? 😄

@jukkar, do you have any comments on the couple of discussions since your last requested change? According to the PR (https://github.com/zephyrproject-rtos/zephyr/pull/68809) which has been merged, yet this issue remains open....

@jukkar, thank you for your reply. By the way, don't you think the PR (https://github.com/zephyrproject-rtos/zephyr/pull/68809) already addresses https://github.com/zephyrproject-rtos/zephyr/issues/68793, but just hinders @EricNRS's use case. What about `OPTION3`, since you haven't...

@jukkar Based on @EricNRS's comment, I came up with another idea to reintroduce the `#define print(sh, level, fmt, ...)` macro, but in a modified version that would be located in...

> > **Pros**: This allows the use of PR macros without a `NULL` check and does not affect other files in `subsys/net/lib/shell`. > > **Cons**: It limits the option of...