Nadia Dencheva comments

Results 156 comments of


                                            Nadia Dencheva

RCAL-856: WCS should roundtrip with sufficient accuracy

This is not needed after all. Closing.

`group_id` in romancal

`group_id` is cheaper to compute from the pool file and add to the association than to compute it when it's needed in the L3 pipeline. All the information needed to...

Describe "phase" parameter in astropy.modeling.functional_models.Sine1D and astropy.modeling.functional_models.Cosine1D

Looking at the[ issue](https://github.com/astropy/astropy/issues/3807) and [the code that added it](https://github.com/astropy/astropy/pull/3940), it was meant as an x- offset. I'm labeling this as a good issue for first time contributors.

Make the WCS evaluation API uniform

Thanks for writing this up @WilliamJamieson and all the comments from others. There are many issues touched on here and many are interrelated. On the surface it seems hard to...

Refactor Coordinate Frames

LGTM. Can you run the regression tests for both pipelines?

BUGFIX fix issue with `with_units` causing a loss of array entries

JWST RT pass: https://github.com/spacetelescope/RegressionTests/actions/runs/14619925947 Roman RT failure is unrelated https://github.com/spacetelescope/RegressionTests/actions/runs/14619946714 JWST unit tests failures are unrelated.

docs -- double link to asdf example

Documentation needs to be cleaned up. New versions of asdf do not allow saving to FITS files.

Duplicate wcs_from_footprints is unused

@stscijgbot-rstdms

Added proposal to modify ds9 to work with ASDF files.

test notificaitons