Quang Nguyen

Results 49 comments of Quang Nguyen

linters are flagging the exec cmds. IMO shelling out commands is not ideal here. I know that AKS has their own SDK that is able to interact with EKS https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/eks...

![image](https://github.com/user-attachments/assets/eeba4aca-f75c-4858-9a16-06d14567cf26) ![image](https://github.com/user-attachments/assets/cf53672c-3551-4710-8b22-1e2704746abd) @SRodi Retina has been running for 18 hours and only two `Added node` logs from the node controller

> was this done with the [migrate](https://golangci-lint.run/product/migration-guide/#command-migrate) command? yes > also can you double check this doesn't break the make fmt recipe? looks like there's a new golangci-lint fmt cmd...

#43227 is for adding ztunnel as a valid encryption type for `cilium status`, which we can then use in the connectivity test suite to check for enablement.

@mmckeen I will try to make a pass this week

Also, I'm all for ditching the reporting period entirely if we can make packet sampling works as it is a lot more flexible than the currently hardcoding value that we...

@mmckeen thanks for the docs! After re-reading it, the sampling calculation makes more sense to me now (I thought by default, the `sampled` variable is set to `false` 😅). Will...

hey @mmckeen , I just merged some changes for conntrack, can you rebase your PR? Thanks!

@VincentS hey, sorry for the delay as I've been busy with other commitments, I've asked the internal team for reviews.