Natanael Copa

Results 207 comments of Natanael Copa

> I would rather see someone else (i.e. upstream) maintain this 🙃 I agree. This is something that should be fixed in kubelet. But for now we will have to...

IIRC the idea came from this: https://github.com/k0sproject/k0s/issues/3096#issuecomment-1542682774 Different filesystems may report used/available disk space differently.

I wonder if it actually makes sense to let k0s sysinfo check filesystem type of `/var/lib/k0s` since datadir is configurable. Maybe it would be better to add something to the...

I would like some kind of explanation in the commit message why this change is needed or what benefit it brings. Something we can refer to in case someone want...

I have a simpler alternative https://github.com/k0sproject/k0s/pull/5193

How is memory usage affected? I assume that the memory usage will go up, but with how much?

please note that this is a low severity issue according upstream. They did not even bother create new upstream release for it.

I don't know if you are aware of it but we already have a [Security Self Assessment](https://github.com/k0sproject/k0s/blob/main/docs/governance/cncf/security-self-assessment.md).

The `make check-reset` test fails: ``` Test: TestResetSuite/TestReset/k0s_reset Messages: /var/lib/kubelet still exists ```

I have been able to reproduce it as well in a fedora vm. ``` / # strace mount -o remount,rw /sys/fs/cgroup execve("/bin/mount", ["mount", "-o", "remount,rw", "/sys/fs/cgroup"], 0x7fff862021d8 /* 7 vars...