k0s icon indicating copy to clipboard operation
k0s copied to clipboard
verified publisher icon k0sproject

Compress k0s binary using UPX

Open twz123 opened this issue 11 months ago • 12 comments

Description

Make this configurable via Make variables.

This is a PoC based on #5468, to see if it is generally possible and to have something to tinker with. CI seems to be passing. The size reduction is about 25% for the linux-amd64 executable, and over 30% for the windows-amd64 executable.

I did some highly scientific ^^ benchmarks using time ./k0s on my machine, to compare startup times of the compressed and uncompressed versions of the executable. For me, compression added around 420 ms of startup latency.

See:

  • #5468

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update

How Has This Been Tested?

  • [x] Manual test
  • [ ] Auto test added

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] My commit messages are signed-off
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

twz123 avatar Jan 23 '25 09:01 twz123

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Feb 22 '25 23:02 github-actions[bot]

How is memory usage affected? I assume that the memory usage will go up, but with how much?

ncopa avatar Feb 24 '25 12:02 ncopa

How is memory usage affected? I assume that the memory usage will go up, but with how much?

Not only memory but also CPU, as it will do decompression to memory on start

s3rj1k avatar Mar 11 '25 17:03 s3rj1k

This pull request has merge conflicts that need to be resolved.

github-actions[bot] avatar Mar 27 '25 13:03 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Apr 26 '25 23:04 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar May 27 '25 23:05 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Jun 27 '25 23:06 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Jul 28 '25 23:07 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Aug 29 '25 23:08 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Sep 30 '25 23:09 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Oct 31 '25 23:10 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Dec 01 '25 23:12 github-actions[bot]