Nikhil Chelliah

Results 8 comments of Nikhil Chelliah

I know this is a change to the global karma.conf.js, so I totally understand if you all don't want to accept this. But FYI @patrickshih-optimizely, this may help you debug...

@patrickshih-optimizely you may want to rebase #479 on top of this. I'll leave it up to you! _One_ of us will definitely have merge conflicts 😆

@tysonmote @gpsamson thank you for the reviews and sorry for the late update! I've pushed some lint fixes; hopefully they help. I'm heading out of office through next week but...

@patrickshih-optimizely thanks very much for taking over! @jenskene yup I left Optimizely last year and stopped getting notifications. Sorry for not posting an update in either PR!

@joostdecock I'm impressed you found time for this! It's looking good I think. I agree linting only needs to be implemented in v3 at this point. I'm pleased to find...

Okay, thanks for the background on that! I'll push the centralized `.eslintrc` to my PR so you can judge how it looks. > The reason things are at a design/olugin/package...

Amazing to come back from vacation and find that one's old PRs are already rebased and incorporated elsewhere! Thank you @eriese, I'll close this and review the changes in #3118....

> ^ Has this been solved by the above merged PR request? If so can it be closed? Mostly done. I think we can close this issue. But I should...