Naïm Camille Favier

Results 190 comments of Naïm Camille Favier

Can this be unified with Cat.Functor.Coherence?

> It looks like only the `runner.temp` in the `tar` command incorrectly refers to the host temp directory. The `runner.temp` in the `upload-artifact` step correctly points into the container. Can...

Does this actually require modifying ofborg or could we just set up a cachix action somewhere?

Fixed by https://github.com/NixOS/nixpkgs/pull/204840, probably?

Apparently not. Ofborg failed to catch a double-wrapped `platforms` in https://github.com/NixOS/nixpkgs/pull/239665/files#r1241160820.

Looks like ofborg uses `pkgs/top-level/release.nix`, which only evaluates packages for the supported platforms... check-meta should happen before that.

I also witnessed wrong review requests in https://github.com/NixOS/nixpkgs/pull/172257, where the bot pinged the `promtail` maintainers (https://gist.github.com/GrahamcOfBorg/cd6a3bd78c37f6b77fc1d39ef8e6ccf3) although i was only touching `makeBinaryWrapper` in `all-packages.nix`. Looks like `all-packages.nix` could be the...

Is this really needed? The GitHub [workflow](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/manual-nixos.yml) already builds the NixOS manual whenever a file in `nixos/` is modified.