ofborg icon indicating copy to clipboard operation
ofborg copied to clipboard

tasks/eval/nixpkgs: build the nixos manual / options to verify them

Open cole-h opened this issue 2 years ago • 5 comments

Just evaluating them isn't enough anymore, now that the docs are lazy.


Maybe we should keep the instantiate step but add the build step? idk

cole-h avatar Aug 12 '22 16:08 cole-h

There's a NixOS option that will allow us to go back to the old way and keep checking at eval-time: documentation.nixos.options.splitBuild = false (thanks pennae!)

Now just need to set that somehow.

cole-h avatar Aug 12 '22 19:08 cole-h

There's a NixOS option that will allow us to go back to the old way and keep checking at eval-time: documentation.nixos.options.splitBuild = false (thanks pennae!)

Now just need to set that somehow.

maybe this but the drv still contains lazy-options.json

nix-instantiate --arg configuration '{ ... }: { documentation.nixos.options.splitBuild = false; }' ./nixos/release.nix -A options

Artturin avatar Dec 02 '22 23:12 Artturin

Is this really needed? The GitHub workflow already builds the NixOS manual whenever a file in nixos/ is modified.

ncfavier avatar Jan 01 '23 16:01 ncfavier

Well, we have two options: 1) make this actually build the manual / don't be lazy when instantiating it; or 2) disable the functionality in ofborg, since we do have GHA setup for that. This is assuming the GHA workflow does indeed catch issues with the manual (I don't know).

cole-h avatar Jan 03 '23 15:01 cole-h

This is assuming the GHA workflow does indeed catch issues with the manual

It does.

I think we can go with 2, unless there's a need to do this in ofborg? GHA are a bit nicer, and they're already working.

ncfavier avatar Jan 03 '23 16:01 ncfavier