Nick Cabatoff

Results 98 comments of Nick Cabatoff

> hi everyone, can I pick this up. That'd be great, thanks @arjunagl .

@arjunagl We don't generally assign issues. Just create a PR and reference the issue in your description.

@archoversight I haven't had time to work on this lately, but I will come back to it soon. In the meantime, a colleague pointed out that your test with `GO_TAGS=netcgo...

I ran into this issue when trying to connect to an onprem bitbucket repo on port 7999. It was confusing because everything worked fine using standalone git. It worked once...

Yeah, I suspect it's a general problem (not azure specific) related to bringing online many nodes for a new cluster at once. Usually (at least pre-k8s) people bring online one...

This looks good, except one concern I have. Doesn't the default config for Opts.OnPotentialDeadlock do an os.Exit(2)? We probably don't want that, right?

Looks like there's a panic, which I think is introduced by this change: ``` [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x43f9231] goroutine 24844 [running]: github.com/hashicorp/vault/command.(*ServerCommand).Run.func2(0xc000095400?) /home/circleci/go/src/github.com/hashicorp/vault/command/server.go:1333 +0x31 github.com/hashicorp/vault/command.(*ServerCommand).Run(0xc00120b860, {0xc002ab21e0, 0x2,...

> But I'll let folks with more knowledge of the codebase to weigh in; let me know if you want me to any changes here! Well, I agree with your...

Hi @esp1, Thanks for reporting this. I could be wrong, but I don't think we control the Vault build in homebrew, unless you use our own tap: https://github.com/hashicorp/homebrew-tap Regardless, from...