Nils Bars comments

Results 7 comments of


                                            Nils Bars

inconsistent port attribute in structs tr_tcp_config and tr_ssh_config

I think the reason for using a char\* is that functions like `getaddrinfo` expect that the port is passed as this type. However I would prefer `unsigned int`, but as...

inconsistent port attribute in structs tr_tcp_config and tr_ssh_config

I would propose the we resolve this issue when we're fixing #4, because this will anyway change the library API.

Create a general test framework for RPKI-RTR client implementations

I started some month ago a framework: https://github.com/nbars/rtrlib/tree/test_framework Here you can see a example test case: https://github.com/nbars/rtrlib/blob/test_framework/tests/test_network/pdu_wrong_length.c What do you think about this approach?

[Bug]: Heap-Buffer-Overflow in `add_rec_header`

Sure, wolfssl has been compiled with the following flags: `./configure --enable-all --enable-aesni --enable-keylog-export --disable-ech`.

Unify environment variable handling

I really dont have time for that, but I guess pull requests are more than welcome :)

STM32F072 TIM15 PWM not working (MOE bit)

This is also the case for TIM15, TIM16 and TIM17 for STM32F030x4/x6/x8/xC and STM32F070x6/xB. I would love to help here but am relatively new to this ecosystem. I guess we...

Allow to set heap limit for v8

Hi @jonmmease, thanks for the swift response. Using VegaFusion works like a charm! I am happy to make a PR. Is it possible to assign me to the issue so...