Michał Praszmo
Michał Praszmo
Started tasks are already cleaned up after a certain timeout (24h): https://github.com/CERT-Polska/karton/blob/master/karton/system/system.py#L84 Is this really needed?
A full state machine diagram + a small description somewhere in the `Advanced concepts` in docs would be pretty cool
Here's a rough overview, you should be able to import it at draw.io and edit it 
Where are the tests? 👀
Hey, thanks for the changes. I like it! AFAIK `KartonState` is used primarily in [karton-dashboard](https://github.com/CERT-Polska/karton-dashboard). I'll see how we could make it compatible with the changes you've proposed :+1:
Yep, was thinking about the same thing. Even iterators would be okay as they are right now but we'd also need to add information about the number of tasks (of...
Okay, did some digging and I think I've spotted all problematic/unoptimal code fragments. * `KartonQueue->pending_tasks` should use the redis queue instead of loading all tasks and dividing them by the...
@msm-cert was more invloved in the discussion so I'll leave the review up to him but I'm thinking if the filter matching is that nontrivial we should probably include a...
Some of the issues seen while testing this in a bunch of different setups: * old karton-system + new karton services - When a service spawns a new task it...