nazarifard

Results 6 comments of nazarifard

> Mus does not allocate the string. Instead, it slices from the input buffer (with `unsafe.Slice`). Changes to the buffer will modify string content. ⚠️ > > This benchmark creates...

However @ymz-ncnk doesn't accept my point yet, But fortunately he fixed the bug and current version hasn't that bug. old versions were using the following these three lines to move...

> Just to be clear. Let's look at two cases. First one: > > ```go > for { > bs := ReadData() // Each time ReadData() returns a new bs!...

@ymz-ncnk I am speaking exactly about the following [line 63 of unsafe string.go](https://github.com/mus-format/mus-go/blob/v0.1.3/unsafe/string.go#L63) Here this line of code was obviously wrong and fortunately its fixed in newer version > v0.1.3...

> I don't want to disappoint you, but this is still true even now (and this is not how the unsafe package should be used): > > ```go > func...

There is nothing to discuss for now. The issue is fixed and last version works finely. We are only sharing our technical insight about a specific topic. By the way...