Navjot Kukreja

Results 26 comments of Navjot Kukreja

We'd love to hear if someone has successfully used Doctr as part of a GitHub action, or if the recommended practice is something else entirely?

> they represent, both syntactically and semantically, the same symbolic entity They do not. For all you know `g1.dimensions` could represent x, y and `g2.dimensions` could represent x, z. The...

> We should update the docstring accordingly, because devito's default names for grid dimensions will be x, y, z I disagree. I think the code creating default dimensions should check...

> we want to reach the end of the test suite having allocated thousands of symbols only for the SpaceDimensions. What is wrong with allocating thousands of symbols when running...

> This is the same assumption every single tensor/array package has. Can you cite a specific example of this? > and should be so. There is very little reason to...

So I think the rationale behind this issue was to combine the interpolation in space and time and move to a common place and @YanivHollander seems to be going there...

I have seen this error myself, recently. Forgot how I resolved it. What python version are/were you using @jazzskier ?

Also, I want to understand if this is significantly different from using PrecomputedInterpolator (i.e. this class could extend and use the functionality there)

@guaacoelho But LinearInterpolator does not do any pre computation. If this class is doing pre computation of coefficients, it could store them in the properties provided by `PrecomputedInterpolator` and use...