Navina Ramesh

Results 18 comments of Navina Ramesh

> Please reformat the changes with [Pinot Style](https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup?q=pinot+style#intellij) > > @navina Can you please help review the PR? To keep the existing behavior, should we put empty string as the...

> Does `groupId` apply to LLC consumer? I checked the usage of `StreamConfig.getGroupId()` and I think we already handled the case of missing group id (in `PinotTableIdealStateBuilder.getGroupIdFromRealtimeDataTable()`). @navina In which...

> Hey @navina , I was looking into partition-level consume but I was unable to find the groupid. Can you please point me to code? As of today, we don't...

@tanmesh sorry about the delay. I was able to verify your patch locally and the integration tests seem to pass now. I think it was some transient failure. I think...

>Please test a multi partition topic with replication enabled. yeah. this patch will break with replication. But what I am unsure about is how this was working before for the...

> @navina @mcvsubbu Is this blocked on something? Some pinot users are asking for this metric . It's not blocked. Haven't been able to circle back to this. Will try...

Closing this in favor of https://github.com/apache/pinot/pull/9515

> if the header is broken but somehow the payload is ok. what's the behavior before/after this change Not sure if I follow what you mean by " header is...

Let's continue any design related discussions in the [design doc](https://docs.google.com/document/d/1kTUfBud1SBSh_703mvu6ybkbIwiKKH9eXpdcpEmhC2E/edit) Thanks!