naushir

The UAPI file is effectively here: https://github.com/raspberrypi/linux/blob/rpi-6.1.y/drivers/media/platform/raspberrypi/pisp_be/pisp_be_config.h This file is duplicated in libpisp/libcamera.

> `V4L2_PIX_FMT_RPI_BE` is said to be `/* Opaque BE format for HW verification. */` > > Does it need to be upstreamed ? Ideally yes if it can. The definition...

> Also I recall that there was a documentation draft for the RAW compressed formats but I don't seem to be able to find it. Any pointer ? There was...

Apart from the setting of ``ret`` commend, looks good to me.

This will break userland, so best to merge this in together with the (soon to be) upstream changes.

@davidplowman and @njhollinghurst we won't merge this yet, but just a heads-up.

@jmondi this is something we should put into the next revision of your upstream driver.

> But while we're at it why don't we remove the I/O addresses (buffer configs) as well, and start from GLOBAL_BAYER_ENABLE? The driver will never touch those address fields (instead...

LGTM!

Just trying these changes now on top of a rpi-6.6.y tree and unfortunately when I run rpicam-apps or cam, I get the following dmesg output: ``` [ 34.710292] pispbe 1000880000.pisp_be:...