linux icon indicating copy to clipboard operation
linux copied to clipboard

drivers: staging: bcm2835-isp: Respect caller's stride value

Open davidplowman opened this issue 1 year ago • 4 comments

The stride value reported for output image buffers should be at least as large as any value that was passed in by the caller (subject to correct alignment for the pixel format). If the value is zero (meaning no value was passed), or is too small, the minimum acceptable value will be substituted.

davidplowman avatar Feb 15 '24 13:02 davidplowman

@naushir @6by9

davidplowman avatar Feb 15 '24 13:02 davidplowman

LGTM!

naushir avatar Feb 15 '24 13:02 naushir

I thought we had this anyway, but I guess not.

Looks fine, although it does give userspace an easy way to allocate masses of memory by artificially inflating the stride. Then again VIDIOC_CREATE_BUFS allows you to do that anyway.

6by9 avatar Feb 15 '24 15:02 6by9

@davidplowman this needs a rebase before merging.

popcornmix avatar Mar 01 '24 11:03 popcornmix

Sorry, failed to spot that this wanted a rebase. Hopefully all good now...!

davidplowman avatar May 21 '24 14:05 davidplowman

Still LGTM

6by9 avatar May 21 '24 14:05 6by9