Gleb Naumenko comments

Results 88 comments of


                                            Gleb Naumenko

net: attempts to connect to all resolved addresses when connecting to a node

Concept ACK

Evicting and filling attack for linking multiple network addresses

Recently, someone at the meetup told me that other projects usually consider this a lost cause. Apparently, it's easier to maintain two separate nodes and connect them if needed. This...

addrman: delete addresses that don't belong to the supported networks

Having these records around might be useful too, if you go back to those networks. Do we have any practical problems with these Select calls? Too much CPU time, orz...

p2p: Don't process mutated blocks

Concept ACK. Looking forward to addressing already pending comments, then i review.

net: call `Select` with reachable networks in `ThreadOpenConnections`

ACK 7edb07ca800991f7c88d582b880a392efe17f31d

Gathering Priorities of 28.0

Erlay #28646

init: fixes file descriptor accounting

ACK d4c7c4009da14c84576d43ab4a1241967cfa5ffc The change makes the code much easier to understand, and I couldn't find any bugs or flaws.

Non-interactive channels without commiting to value in script pubkey

I think this is a great idea and worth consideration in the discussion of the covenants. It would be great to see which covenants enable this and at what cost/risks....