Gleb Naumenko

Results 88 comments of Gleb Naumenko

>Did you think about a -disablerecon command or something similar, to not activate Erlay until all the parts have been merged? Yeah I was also thinking about how it's weird...

Still going through comments, beware it's not the final shape from my side.

Rebased and addressed most of the comments. The only remaining thing is to make functional tests for this. I'm working on that.

@glozow [in the discussion above](https://github.com/bitcoin/bitcoin/pull/23443#discussion_r764474638) we were not sure what to do with nodes signaling fRelay=0, because they might later enable tx relay via bloom filters (SPV etc.). Disconnecting for...

@glozow took your suggestion, updated the bip

The PR is ready for review again! Please take a look.

@ariard @jonatack addressed all comments and rebased, please review :)

Concept ACK, light code review ACK 47c0d02f126c73755288c3084402098567964329

Concept ACK. Moving forward with BIP324 is a good idea, and this code seems to not have any negative/unexpected side-effects.

Okay, a lot of things here: 1. I like the consolidation because it removes code. 2. I don’t see a big difference between a no-op and throwing an error? 3....