Gleb Naumenko
Gleb Naumenko
Still have to review a couple of comments, especially the fuzzing [suggested](https://github.com/dergoegge/bitcoin/commits/2022-10-erlay2) by @dergoegge
This PR is good for review. Fuzzing will come in a separate PR.
I decided to split this off into #28765.
Great to see this, I hope this functionality comes into Bitcoin one way or another, and this seems like a decent attempt. Your listing of the features makes sense, and...
I reviewed the code f636daf4c89da7b2b72d05e73de1ca86449a36a6 and it seems correct. However, I think the other approach #27018 makes more sense. Not just because of the particular reorg issue, but in general...
@theStack I think the philosophy behind v2 was always "prevent the firewall from discriminating authenticated connections by making them look exactly like non-authenticated (but also encrypted) connections". From [BIP](https://github.com/bitcoin/bips/blob/master/bip-0324.mediawiki): >Encryption,...
Concept ACK, specifically on changes to the eviction logic, and handling bloom filters. Numbers also seem fine I guess. I was curious whether there is (or will be) any other...
I'm curious about some back-of-the-envelope estimates on the memory use: block-relay-only, tx-relay, and the node in general. That would help to understand the impact of such a patch. Also, do...