Gleb Naumenko
Gleb Naumenko
I'm not a big mempool expert, but this seems like a good direction. --------------- 1. There are obvious typos and misalignments you're probably aware of, i assume we shouldn't merge...
>Though I agree this seems more like an implementation question than a spec question. In the spec, I would leave it as "the receiver may respond with notfound." The thing...
Good stuff overall. I kinda feel this document is too in-depth for now, and should be simplified to: 1. Focus on the simplest version first. 2. Focus attention on high-level...
ACK 17028c1fec3f109b139e5e23f535c86f5a1ac2a4
Concept ACK. I think the 43% saving is a big deal, and the code change amount seems fine, although worth prototyping those corner cases first :) W.r.t. the security reduction...
ACK fa4d9d5b39d5652de1d83564f19b1a0749863b16 There are many more tests possible, right? E.g. sending more than 4095 bytes of garbage. I assume the goal here wasn't to cover everything?
ACK bc9283c4415a932ec1eeb70ca2aa4399c80437b3
@ariard Can you tell if my description is correct? When Alice and Bob are not friends, Bob can waste Alice's resources by: 1. Inviting to open a dual-funded channel below-minrelayfeerate...
~Marking this draft until~ 1. ~~[Previous PR is merged](https://github.com/bitcoin/bitcoin/pull/23443)~~ [Follow-up is merged](https://github.com/bitcoin/bitcoin/pull/26359) 2. ~There is one in-code TODO I have to resolve (it is minor, but it has to be...
@aureleoules fixed all you pointed out. Note that the last two commits are WIP, as I'm looking for a confirmation that those two are indeed an improvement. If yes, then...