Natalie Mclaren comments

Results 7 comments of


                                            Natalie Mclaren

style: [internal] Update headers to align size, weight and line-height with product library styles

> Is it possible to make if dependent on the font? Or you don't think that is a good idea in CSS? @anaf it's possible but it would make our...

style: [internal] Update headers to align size, weight and line-height with product library styles

> Can we start small and use a system that can be applied to both fonts? If possible, using a [multiplier based on the font size](https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#prefer_unitless_numbers_for_line-height_values) is the most recommended....

style: [internal] Update headers to align size, weight and line-height with product library styles

@frankieyan sounds good 👍🏼 In my latest commit I've addressed your other comments (deprecating `size` and removing redundant variables). I will wait for Ana's comments on the above before moving...

style: [internal] Update headers to align size, weight and line-height with product library styles

Hey @anaf, just checking in to see if there have been any updates on this? :) let me know once everything is updated on Figma so I can update the...

style: [internal] Update headers to align size, weight and line-height with product library styles

Closing after discussion held [here](https://twist.com/a/1585/ch/81455/t/3712772/) with new deliverables, let's create a new PR for this when addressed.

onSubmitted not working with functions

Hi, history.push is taken from react router's useHistory() - it allows you to programatically set the next route. Unf no luck, I've tried `document.location.href="/thank-you";` however it kept re-rendering the component...

Cannot read property 'getBoundingClientRect' of null

I'm having this issue at the moment, I have a component as the `` child but it isn't rendering. Can you clarify where this 'ref' would go if this is...