Natalia Mokeeva
Natalia Mokeeva
> > but what should we do with aliases which are the same for both: period and offsets, such as "D", "B", "W", "WEEKDAY", "W-SUN”, etc.? > > I think...
> @natmokval you'd done a bunch of work in this area, so this might be interesting to you to try fixing? > Yeah, sure, I would like to work on...
@MarcoGorelli could you please take a look at this PR? I think CI failures are unrelated to my changes.
@MarcoGorelli, could you please take a look at this PR?
I replaced `freq_to_period_freqstr` with `PeriodDtype(obj)._freqstr / PeriodDtypeBase(obj._period_dtype_code, obj.n)._freqstr`. Now we don’t need the `function freq_to_period_freqstr`, which is why I removed it. One comment: In `pandas/core/arrays/period.py` in the definition of `raise_on_incompatible`...
Here is the list of PR’s enforced by CLN: enforce deprecation of frequencies deprecated for offsets #57986: - [x] #56092 - [x] #55978 - [x] #56050 - [x] #55496 -...
> thanks! this is probably good, will do another pass over tomorrow / in the week thank you for helping me with this PR!
> looks good to me on green, thanks @natmokval ! thank you for reviewing this PR!