Natalia Mokeeva

Results 18 comments of Natalia Mokeeva

> @natmokval can you check off the boxes above that you have already handled. i think you've done a bunch of them thanks @jbrockmendel. I tried to check the boxes...

> @natmokval - that's surprising, I would think triage permissions would allow you to edit any comment. Are you able to edit this comment? > no, I can't edit this...

> Thanks @natmokval - I've checked off all PRs. > thanks @rhshadrach. > > I noticed a couple of missing PRs, which are need to be checked off too: >...

Thank you for working on this @mattheeter. It looks good to me. I think the suggested changes will fix the bug in `is_year_start` for `MonthBegin`. We will get the correct...

I think it's okay to leave the fix for `"MS"` in this PR and open a new PR to work on the problem for frequencies such as `"QS-NOV"`. This PR...

I enforced deprecation of aliases `M, Q, Y, etc.` in favour of `ME, QE, YE, etc.` for offsets, ci - green. @MarcoGorelli could you please take a look at this...

> Thanks for updating! A few things > > * good to have the `c_PERIOD_TO_OFFSET_FREQSTR` dict, but I don't see why it's being used here: > ```python > if not...

> * `lowrecase` typo thanks, I corrected the typo

> * is this part temporary > ```python > elif name in {"d", "b"}: > name = name.upper() > elif (name.upper() not in {"B", "D"} and > not name.upper().startswith("W")): >...

> thanks for explaining - is there a way to do that part without using `c_PERIOD_TO_OFFSET_FREQSTR`? let's try to separate them out a bit more, if `c_PERIOD_TO_OFFSET_FREQSTR` is for mapping...