Nathan Mc Grath
Nathan Mc Grath
Thanks for taking this up @rvanasa!
So have we thrown in the towel on this one? Shall we close this ticket?
Agreed. At least we did make some improvements along the way so it wasn't a _total_ waste of time :D
But then setting type to 'before', the error handler won't catch the error! 😆 Disabling the default error handler and setting the type back to 'after' seems to be working...
Is that the case for just 'after' typed middleware? It makes sense as to why this issue happens now that I've played around with it and I've got working middleware...
Awesome. It's not common to use Vite with Angular though, so I'm working on a plugin for Angular CLI that will work with DFX. Once I finish this, I'll make...
@krpeacock it would be good to get your opinion on the interface here. I've kept it so that `Certificate.lookup()` has the same behaviour as before. To get the new lookup...
> @nathanosdev I think that extending the changes to the `lookup` and also exporting `lookup_path` is a fine path forward. > > I'd rather not also introduce the retry logic...
@krpeacock I've extended the changes to the `lookup` method now and used the `lookupResultToBuffer` everywhere that references the `lookup` method to keep the same behaviour as before for internal calls...
It doesn't seem happy with it still, the error message is `Error: Must use import to load ES Module: /action/node_modules/conventional-changelog-angular/src/index.js`