awesome-internet-computer icon indicating copy to clipboard operation
awesome-internet-computer copied to clipboard

Published 20 hours ago • verified publisher icon dfinity

Listing on the awesome list of awesome lists

Open nathanosdev opened this issue 2 years ago • 8 comments

This list would fit right in here: https://github.com/sindresorhus/awesome#decentralized-systems I'm happy to open a PR over there if there's agreement.

nathanosdev avatar Sep 16 '22 10:09 nathanosdev

Hey @nathanosdev ,

seems like a good idea, but we should postpone this a bit for two reasons:

  1. The content is pretty dated
  2. We need to think about renaming/rebranding to awesome-ic / awesome-internet-computer. (Herbert curates https://github.com/zire/awesome-IC but we have much more watchers/starts here)

domwoe avatar Sep 16 '22 10:09 domwoe

Makes sense, thanks! Would you like to keep this ticket open for the future then or close it?

nathanosdev avatar Sep 16 '22 10:09 nathanosdev

Let's keep this open. We shouldn't forget this.

domwoe avatar Sep 16 '22 10:09 domwoe

@nathanosdev Please go ahead! :)

domwoe avatar Sep 20 '22 11:09 domwoe

Thanks @domwoe. I read their contribution guidelines and it turns out there's a bit more work to do to make sure that my PR over there is accepted, I've prepared a PR with most of the necessary changes: https://github.com/dfinity/awesome-icp/pull/32. I'm happy to discuss alternatives to any changes that I made there, but I made what I felt was the most obvious change to me (like the license for example) to begin with so we have something to work from.

2 action items that cannot be covered in the PR that I could use your help with are:

  • renaming the primary branch to main instead of master
  • adding awesome-list & awesome to the GitHub topics.

nathanosdev avatar Sep 20 '22 14:09 nathanosdev

Thanks a lot! Should be good to go now

domwoe avatar Sep 21 '22 07:09 domwoe

Ah I'm sorry, I didn't run the linting tool again after adding the contributing section so I missed this:

$ npx awesome-lint https://github.com/dfinity/awesome-icp
✖ Linting

  README.md:19:1
  ✖  19:1  Table of Contents must be the first section  remark-lint:awesome-toc

  1 error

Fix is here: https://github.com/dfinity/awesome-icp/pull/33

nathanosdev avatar Sep 21 '22 11:09 nathanosdev

PR has been opened here: https://github.com/sindresorhus/awesome/pull/2390

Fingers crossed 🤞

nathanosdev avatar Sep 21 '22 16:09 nathanosdev

Updated PR:

  • https://github.com/sindresorhus/awesome/pull/2525

rvanasa avatar Feb 13 '23 19:02 rvanasa

Thanks for taking this up @rvanasa!

nathanosdev avatar Feb 13 '23 19:02 nathanosdev

So have we thrown in the towel on this one? Shall we close this ticket?

nathanosdev avatar Mar 08 '23 09:03 nathanosdev

@nathanosdev Yes. I've asked @rvanasa for feedback before and we think it's better to provide a useful list of resources than to strictly adhere to some arbitrary rules.

domwoe avatar Mar 08 '23 11:03 domwoe

Agreed. At least we did make some improvements along the way so it wasn't a total waste of time :D

nathanosdev avatar Mar 08 '23 12:03 nathanosdev