Nathan Cochran comments

Results 4 comments of


                                            Nathan Cochran

Cursor: avoid closing connection twice if error received after destroy()

I am running into this issue as well (see my [comment](https://github.com/brianc/node-postgres/issues/1674#issuecomment-1563287449) on #1674). I believe this PR would fix my problem. Would love to see this get merged!

Cursor: avoid closing connection twice if error received after destroy()

> I see you have a neat repro at https://github.com/brianc/node-postgres/issues/1674#issuecomment-1563287449; any chance you can test this patch against that? @alxndrsn Just tested it, and it does indeed fix the issue!...

Cursor: avoid closing connection twice if error received after destroy()

@alxndrsn It does seem somewhat different, in that my repro is attempting to cancel the query (which triggers an error in the database for that query - I'm not entirely...

Cursor: avoid closing connection twice if error received after destroy()

> If the test is good, any objections to adding it to this PR? @alxndrsn Go for it! Thank you!!