Nate Bosch

Results 198 issues of Nate Bosch

We are temporarily pinning to `ubuntu-20.04` instead of `ubuntu-latest`. `mono_repo` does not support anything than `ubuntu-latest`, so the change are being made manually and the self validate step is being...

Currently if a web test causes the browser page to crash (like a memory leak causing an OOM error) then we'll report the test as "did not complete", but it's...

We disallow imports to `dart:io` in our production toolchains: webdev, bazel. We currently allow imports in flutter, and when running web tests, with runtime failures instead. To avoid surprises -...

type-enhancement

See https://github.com/dart-lang/sdk/issues/46756

type-enhancement
status-blocked

Since `fail` is `throw TestFailure` we can get into a situation where an async failing `expect` call in some error handling zone will not result in a test failure. https://github.com/dart-lang/test/blob/e0be5ec076c59d621de1892b108727f560f217bc/pkgs/test_api/lib/src/expect/expect.dart#L109...

https://github.com/dart-lang/test/blob/d6329d676c7578c984a5397a6cc4002757c0b21e/pkgs/test/lib/src/runner/browser/browser_manager.dart#L129-L133 We seem to hit timeouts much more often on github actions.

Adding a static type makes the API easier to use correctly. The call site can easily inline the `Uri.parse` if necessary.

next-breaking-release

The VM started giving us different, significantly truncated `StackTrace` instances when running in the zone for `Chain.capture`. `Frame.caller()` relies on parsing `StackTrace.current` which no longer contains the caller we were...

I cannot find any uses of the `Chain.disable` API outside of the tests in this package. It is unnecessary complexity. Removing the functionality may also remove some of the overhead...

next-breaking-release

The doc comment has been misleading, likely since the `when` argument was introduced. There is some nuance to how the argument interacts with the presence of the `onError` argument that...