Nate Bosch

Results 719 comments of Nate Bosch

> Let's make the Null Safe release a new major version, that should let us fix things like this. We _really_ hope to be able to do that 😄

I have definitely used the implementation view before, but I don't know if it's ever been critical for me. Defaulting to collapsed sounds like a good compromise to me.

> Ideally, you should never have a `Future` to begin with, like you should never have a `Future`. > Can you say something about the code that needed it? (Why...

I do like the combination of ```dart CancelableOperation thenOperation( void Function(T, CancelableCompleter) onValue, {void Function(Object, StackTrace, CancelableCompleter)? onError, void Function(CancelableCompleter)? onCancel}) { ``` With `Completer.completeOperation`. With these the solution feels...

I was just thinking that it's too bad the more general version can't be named `.then` instead of `.thenOperation`... it turns out I'm the one to blame 😢 https://github.com/dart-lang/async/pull/81#issuecomment-480007339 I...

We have a PR in `RetryClient`, which is interesting to consider. https://github.com/dart-lang/http/pull/679 I wondered what it would look like to need to migrate this to a retry around `CancelableOperation` and...

> Anyway, for the retry, I'd consider just ignoring the synchronous case and always `await` the `FutureOr`. > Then you can also combine the two calls to `completer.complete*`: Yeah, we...

Another use case that came up is wanting to add an extra `onCancel` behavior to an existing `CancelableOperation`. There is a usage of `CancelableOperation.then` where it seems they expect the...

I'm not convinced that these changes are any better or worse than what we have. I would be OK with splitting a couple of these into more fine-grained categories and...

It looks like we intentionally only allow options that match a pattern which doesn't include `.`, but that isn't documented anywhere. https://github.com/dart-lang/args/blob/5acb553c0ed2b68c5208c79d123ef1d49be7fdeb/lib/src/parser.dart#L230 At a minimum we should document this on...