dart-vim-plugin
dart-vim-plugin copied to clipboard
dart-lang
when meet class typedef extends. it is bad
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
Now It look like this, not all oriange
Now it looks like this
Whit some change
Now I have some question about on
if on should also be red or extends, with implements to purple
of not change anything?
And I also have some problem about the void's color. if should it be red..
I have reservations about moving the symbols too - the existing categories map to the language definitions and I'd prefer to preserve that if we can. I understand that sometimes users want to customize what things look like, but I hope that can be done entirely by overriding the associated highlight for a syntax group in their own .vimrc.
@chen244 - it's not clear to us why late and final were highlighted differently in the first example you shared. They are both in the same group, so they should both look the same at the moment.
I tested this locally and can confirm that they do. Actually, I saw them differently at first because I had a stale dart.vim syntax file from a long time ago (before late was added). After I updated to the current version in master, I see them as the same syntax color (and in your color scheme above they would both be "red" )
I'm not convinced that these changes are any better or worse than what we have.
I would be OK with splitting a couple of these into more fine-grained categories and linking them back to their current category, then you could add some personal highlight definitions linking them differently.
Is there a more high level description you could give us about why you feel like the current categories we have don't make sense for these keywords?
I'm not convinced that these changes are any better or worse than what we have.
I would be OK with splitting a couple of these into more fine-grained categories and linking them back to their current category, then you could add some personal highlight definitions linking them differently.
Is there a more high level description you could give us about why you feel like the current categories we have don't make sense for these keywords?
Because in vscode, and treesitter, class type and "class" are different , and late and int is different. When I use this one ,They are all the same color. So I just want to make they are different.
+1, class should have a unique color. We use class a lot in Flutter projects, because "everything is a widget".
Closing this, as it is a few years old now. Feel free to reopen in case you still want to land it!
