natalie comments

Results 10 comments of


                                            natalie

Making changes in sapling-crypto to use NoteCommitment in zebra (make API public)

Changes here: https://github.com/zcash/sapling-crypto/issues/163. Need to wait for this to be approved.

Add min_signers to PublicKeyPackage

This was completed by PR #912

Add `startingheight` field to `getpeers` RPC

Closing. We will implement this if requested.

feature: match zcashd RPC error codes

We have decided to not do this work and instead respond to needs as they arise

cleanup: Return more concrete errors from the state service

Hey team! Please [add your planning poker estimate](https://app.zenhub.com/workspaces/Engineering-5fb24d9264a3e8000e666a9e/issues/gh/ZcashFoundation/zebra/9730?planning-poker) with Zenhub @arya2 @oxarbitrage

DoS vulnerability in `getblocktemplate` RPC

Yes exactly. But, if you both feel it should be done, then let's prioritise it. I've added it back into the milestone.

cleanup: remove serde Serialize/Deserialize from Block, Transaction

Thank you for this PR. We will take a look at this.

Zebra error on Pi

Thanks for this, we'll take a look

<autogenerated-issue>

Thanks for this. Are you able to give us any more context please?

refactor(zebrad/tests): modularize acceptance tests

Thanks for this, we'll take a look shortly