Nichols A. Romero
Nichols A. Romero
This is something that is needed for PyTorch as well and is not present in ROCm 6.2. The CMake module should include IMPORTED targets as well.
Thanks @jrmadsen for the quick reply. I found a buglet and hope the it can be that it will *not* be too much work to address: https://github.com/ROCm/rocprofiler-sdk/issues/21
@jrmadsen Hoping you can clarify this questions or point us to the relevant documentation. Is `librocprofiler-sdk-roctx.so` compatible with `libroctracer64.so`? As an initial step in the transition, I only included `rocprofiler-sdk-roctx`...
Might be able to preserve provenance by not doing the "squash" during the merge.
This is a subtle bug that has been present for a while. I discovered it post PyTorch 2.6 release. Cherry picked from upstream and will need to be cherry picked...
!cherry-pick --onto release/2.5
!cherry-pick --onto release/2.6
@jrmadsen This command doesn't seem to work at the moment `wget https://github.com/ROCm/omnitrace/releases/latest/download/omnitrace-install.py` It looks like `omnitrace-install.py` is missing in the latest release. Instead, I tested with v1.12.0. Seem to be...
This is a performance improvement from upstream. So far, there have been no negative reports w.r.t. to performance. So, I think it's worth backporting. I will also add it to...
!cherry-pick --onto release/2.6