pore-c icon indicating copy to clipboard operation
pore-c copied to clipboard

Use pyranges for overlap logic

Open eharr opened this issue 5 years ago • 3 comments

Some of the overlap logic implemented in GenomeIntervalDf could be replaced with calls to the better documented and tested pyranges api.

eharr avatar Nov 12 '19 15:11 eharr

Actually, the NCLS is tested extensively in the pyranges tests, but indirectly.

endrebak avatar Nov 13 '19 09:11 endrebak

Actually, the NCLS is tested extensively in the pyranges tests, but indirectly. Ah sorry, I meant better tested than the pore-c implementation.

eharr avatar Nov 13 '19 13:11 eharr

Also, I would love to help out if you have reasonable feature-requests for pyranges. Or feel free to ping me for help :)

endrebak avatar Nov 13 '19 14:11 endrebak