dorado icon indicating copy to clipboard operation
dorado copied to clipboard

Add argument to explicitly enable progress bar output

Open GeorgeNikitinNV opened this issue 2 years ago • 8 comments

Problem: after v0.3.0 progress bar is not displayed if dorado is run not from tty.

Solution: added additional argument to explicitly enable progress bar output, not displayed if omitted:

Optional arguments:
...
  -p, --enable-progress-bar     Enable progress bar output to stderr 
...

GeorgeNikitinNV avatar Jul 26 '23 03:07 GeorgeNikitinNV

Not sure why the tests failed, on my machine everything is fine:

❯ ctest --test-dir cmake-build                        
Internal ctest changing into directory: /Users/george.nikitin/dev/dorado/cmake-build
Test project /Users/george.nikitin/dev/dorado/cmake-build
    Start 1: dorado_tests
1/1 Test #1: dorado_tests .....................   Passed  108.46 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 108.52 sec

Also have no clue how to force checks to restart - should I make another commit for that?

GeorgeNikitinNV avatar Aug 17 '23 03:08 GeorgeNikitinNV

Anyone?

GeorgeNikitinNV avatar Aug 21 '23 00:08 GeorgeNikitinNV

looks like the checks passed now? I think there's some intermittency in the GitHub builds based on how much disk space the test job gets

tijyojwad avatar Aug 21 '23 03:08 tijyojwad

yes, they do

GeorgeNikitinNV avatar Aug 21 '23 04:08 GeorgeNikitinNV

@GeorgeNikitinNV the diff has your CMakeCache.txt included plus some submodules deltas.. might be easier to resubmit a new request from the head of master.

iiSeymour avatar Aug 21 '23 16:08 iiSeymour

would LOVE to see this PR get merged before the next release!

@GeorgeNikitinNV

palakpsheth avatar Sep 06 '23 00:09 palakpsheth

This would be very useful for me, I run Dorado on a HPC environment and it'd be very useful to know how it's progressing.

Shians avatar Feb 11 '24 21:02 Shians